Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveview support to the CLI and make fullstack runnable from dist #2759

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Aug 1, 2024

Fixes #2530
Fixes #2701

@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program labels Aug 1, 2024
@ealmloff ealmloff marked this pull request as ready for review August 1, 2024 18:49
@jkelleyrtp jkelleyrtp merged commit e5e578d into DioxusLabs:main Aug 2, 2024
14 checks passed
@chungwong
Copy link
Contributor

@ealmloff
This (at least) breaks fullstack

-dioxus = { git = "https://github.com/DioxusLabs/dioxus.git", rev = "443b9a4" }
+dioxus = { git = "https://github.com/DioxusLabs/dioxus.git", rev = "e5e578d" }
Dioxus @ v0.5.4 [13:19:16]

    > Hot Reload Mode: RSX
    > Watching: [ src, assets, Cargo.toml, Dioxus.toml ]
    > Custom index.html: None
    > Serve index.html on 404: True

    > Build Features: [ server ]
    > Build Profile: Debug
    > Build took: 159138 millis

thread 'main' panicked at /home/chung/.cargo/git/checkouts/dioxus-1e619ce595d3799d/e5e578d/packages/fullstack/src/serve_config.rs:88:57:
Failed to find index.html. Make sure the index_path is set correctly and the WASM application has been built. Tried to open file at path: "/home/chung/repos/project/dist/public/index.html"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The generated index.html is directly under dist , i.e.
/home/chung/repos/project/dist/index.html
But the new change expects
/home/chung/repos/project/dist/public/index.html

@ealmloff ealmloff deleted the fullstack-assets-nested branch August 2, 2024 03:34
@ealmloff
Copy link
Member Author

ealmloff commented Aug 2, 2024

The generated index.html is directly under dist , i.e. /home/chung/repos/project/dist/index.html But the new change expects /home/chung/repos/project/dist/public/index.html

You need to update the CLI to use the same commit of dioxus as you use for fullstack. You can install the git version of dioxus-cli with cargo install --git https://github.com/DioxusLabs/dioxus dioxus-cli --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Related to the dioxus-cli program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to run the output of a build/bundle for fullstack application Liveview with dx failing
3 participants