Fix WSL Hot Reload #2721
Merged
Fix WSL Hot Reload #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DogeDark
added
bug
jkelleyrtp
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WSL has issues propagating file modification events to our CLI through the
notifycrate. We use notify's poll watcher to fix this when we detect a WSL host. Additionally, this PR adds a new CLI setting to specify the poll interval as it can consume resources for larger projects.wsl-file-poll-intervalCLI setting--wsl-file-poll-interval=serve argumentdx config setcommand usagesettings.tomlwith a non-complete directory structure could fail.Closes #1867