Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2378: CLI MSRV and add MSRV to CI #2716

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Fix #2378: CLI MSRV and add MSRV to CI #2716

merged 5 commits into from
Jul 27, 2024

Conversation

jkelleyrtp
Copy link
Member

@jkelleyrtp jkelleyrtp commented Jul 26, 2024

  • Fix: bump msrv up to be valid for cli
  • add binstall check to ci
  • adjust msrv of tomls

Unfortunately due to a number of changes in our upstream and our own syntax uses, we have to move our msrv up to 1.79

It'd be nice to support lower versions

Fixes #2378

@jkelleyrtp jkelleyrtp changed the title Fix CLI MSRV and add MSRV to CI Fix #2378: CLI MSRV and add MSRV to CI Jul 26, 2024
@jkelleyrtp jkelleyrtp requested a review from ealmloff July 27, 2024 00:20
@jkelleyrtp jkelleyrtp enabled auto-merge (squash) July 27, 2024 00:23
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This has been on the todo list for a while

@jkelleyrtp jkelleyrtp merged commit c4e55c7 into main Jul 27, 2024
13 checks passed
@jkelleyrtp jkelleyrtp deleted the jk/add-msrv branch July 27, 2024 00:24
@ealmloff ealmloff added ci github ci tweak Small changes to improve experience labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci github ci tweak Small changes to improve experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dioxus CLI MSRV
2 participants