Don't panic when not using manganis #2675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkelleyrtp
approved these changes
Jul 23, 2024
|
This is good in theory but magnanis can't really be disabled when running with the CLI - it seems like there's a bug in the magnanis-cli-support crate that's causing it to crash and/or not make that output file. We shouldn't be unwrapping there, but we also shouldn't be panicking upstream. This really isn't the right fix for that issue - can you do some sleuthing to figure out what's actually causing the MG json file to not exist? With that can we also turn that into a proper github issue? |
|
I dug into manganis, and have fixed the issue: DioxusLabs/manganis#46. Just a classic NixOS issue :) This explains why the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.