Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty web history prefixes #2621

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

ealmloff
Copy link
Member

An empty prefix was formatting routes with two leading slashes which caused the router to try to navigate to the wrong location. This PR filters out any empty prefixes

Fixes #2616

@ealmloff ealmloff added bug Something isn't working web relating to the web renderer for dioxus router Related to the router implementation labels Jul 10, 2024
@ealmloff ealmloff changed the title Fix empty prefixes Fix empty web history prefixes Jul 10, 2024
@jkelleyrtp jkelleyrtp merged commit 96450a1 into DioxusLabs:main Jul 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working router Related to the router implementation web relating to the web renderer for dioxus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fresh Dioxus project (web, router on, vanilla JS) doesn't work on current main branch
2 participants