Update dioxus_desktop::Config to also allow for asynchronous custom protocol handlers
#2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3rpp
changed the title
dioxus_desktop::Config to also allow for asynchronouse custom protocol handlersdioxus_desktop::Config to also allow for asynchronous custom protocol handlers
ffs me ffs 2: elctric boogaloo added documentation for asynchronous custom protocol handling
jkelleyrtp
approved these changes
Jun 18, 2024
jkelleyrtp
added
enhancement
DogeDark
pushed a commit
to DogeDark/dioxus
that referenced
this pull request
Jul 3, 2024
Added asynchronous custom protocol handling
Closed
DogeDark
pushed a commit
to DogeDark/dioxus
that referenced
this pull request
Jul 4, 2024
Added asynchronous custom protocol handling
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple PR, that is tested to work on my Fedora machine, although I'm unable to do any real testing on other OSs.
For some reason
wrydoesn't like using synchronous custom protocols, I'm sure you've experienced that since it appear's you're also using the asynchronous one, so I've added an extra config option that adds asynchronous ones.this is gonna be a case of certified ISO 9000 - Works on my machine, as such I encourage others to test on their machines.
Also added a QoL fix that allows the passing of anything that implements
ToStringinstead of a string, since it may be a safe assumption that most of the time, it'd be passed in as a string literal.