Replace RwLock::try_read with RwLock::read in SyncStorage

[ribelo]

Replace RwLock::try_read with RwLock::read in SyncStorage

This pull request replaces the use of RwLock::try_read with RwLock::read in the SyncStorage.

This change prioritizes potential deadlocks over panics. Unwrapping a failed try_read can lead to unexpected behavior and difficult-to-debug issues. Using RwLock::read ensures that the code will always block until a read lock is acquired, preventing potential panics but introducing the possibility of deadlocks.

This change is consistent with the current use of RwLock::write for write operations.

Changes:

• Replaces RwLock::try_read with RwLock::read in SyncStorage.

Rationale:

• Prioritizes potential deadlocks over panics.
• Ensures consistent API with RwLock::write for write operations.

Potential Issues:

• This change might introduce the possibility of deadlocks in scenarios where the read lock is consistently blocked, but all test passed.

[ealmloff]

Yes, this is a bug. This was fixed for try_write a while back, but I forgot to update try_read. Thank you!