Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if cli-config is not available at compile time #2135

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

ealmloff
Copy link
Member

When a package tries to read the CLI config and fails, it is currently a runtime warning. This changes it to a compile time warning

Closes #2089

@ealmloff ealmloff added cli Related to the dioxus-cli program tweak Small changes to improve experience labels Mar 25, 2024
@jkelleyrtp jkelleyrtp merged commit 460a685 into DioxusLabs:main Mar 27, 2024
5 of 6 checks passed
@ealmloff ealmloff deleted the build-error-cli-config branch March 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the dioxus-cli program tweak Small changes to improve experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn at compile time if the CLI config cannot be read in a crate
2 participants