Check type of launch config #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
breaking
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Played around with it locally but not super happy with it since we still have the platform methods here that don't work with the config they specify. Will likely punt on it unless there's a quick fix to allow Builder::desktop().with_cfg() |
Builder::desktop().with_cfg()now works even if you have the |
ealmloff
force-pushed
the
make-config-typed
branch
from
b9a2106 to
2a33e6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue a couple times while updating apps to the new launch builder API. The launch builder currently accepts any type and silently fails when you pass it the wrong type.
This can lead to situations where you pass in a config and see no errors, but your config is not applied.
This PR changes the launch builder to check the type of the config at compile type instead of using a boxed any type.