Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hot-reload as config option with default to true #2024

Merged
merged 1 commit into from
Mar 8, 2024
Merged

added hot-reload as config option with default to true #2024

merged 1 commit into from
Mar 8, 2024

Conversation

rtretter
Copy link
Contributor

@rtretter rtretter commented Mar 8, 2024

Closes #1808

@jkelleyrtp jkelleyrtp requested a review from ealmloff March 8, 2024 20:32
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Mar 8, 2024

LGTM - @ealmloff I haven't looked at CLI-config in a while - does it LGTY?

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@ealmloff ealmloff merged commit 8eda67e into DioxusLabs:main Mar 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make hot reloading the default or add an option to make it the default in the config
3 participants