Only poll suspended futures, lazy memos #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
marc2332
reviewed
Mar 6, 2024
jkelleyrtp
changed the title
|
Looks great :) Clean diff, straightforward code. I like that we collapsed the DirtyScopes into VirtualDom. Fantastic work, thanks! |
jkelleyrtp
approved these changes
Mar 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes suspense polling futures that are unrelated to suspense. This will fix some hydration errors including #1804.
Currently during suspense, all futures that have been spawned will be polled until suspense is finished. This causes hydration issues if a future finishes on the server but not the client and renders different content.
Fixes #2003
Fixes #1935