-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MathML Core support to rsx #1846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/// [`<semantics>`](https://developer.mozilla.org/en-US/docs/Web/MathML/Element/semantics) | ||
/// element. | ||
semantics "http://www.w3.org/1998/Math/MathML" { | ||
encoding: String DEFAULT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semantics element doesn't accept an encoding, unless I misread the spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it does:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, interesting. The MathML Core spec seems to not mention it https://w3c.github.io/mathml-core/#semantics-and-presentation
Will we need a MathML equivalent of this? dioxus/packages/html/src/global_attributes.rs Line 1643 in 53727b3
|
Yes, we should also change dioxus/packages/html/src/elements.rs Line 148 in 53727b3
To apply svg global attributes only to the svg namespace instead of every namespaced element |
@stefnotch @ealmloff |
This PR adds a MathML Core support to the rsx as discussed in issue #1778.
Deprecated tags and attributes are not included in the code base.
annotation-xml is aliased to annotationXml due to the naming restrictions of rsx macro.
@stefnotch @Jah-On