Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MathML Core support to rsx #1846

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Conversation

Ameyanagi
Copy link
Contributor

This PR adds a MathML Core support to the rsx as discussed in issue #1778.

Deprecated tags and attributes are not included in the code base.
annotation-xml is aliased to annotationXml due to the naming restrictions of rsx macro.

@stefnotch @Jah-On

Copy link

@Jah-On Jah-On left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ealmloff ealmloff merged commit 53727b3 into DioxusLabs:master Jan 19, 2024
10 checks passed
@ealmloff ealmloff mentioned this pull request Jan 19, 2024
/// [`<semantics>`](https://developer.mozilla.org/en-US/docs/Web/MathML/Element/semantics)
/// element.
semantics "http://www.w3.org/1998/Math/MathML" {
encoding: String DEFAULT,
Copy link

@stefnotch stefnotch Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The semantics element doesn't accept an encoding, unless I misread the spec

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, interesting. The MathML Core spec seems to not mention it https://w3c.github.io/mathml-core/#semantics-and-presentation

@stefnotch
Copy link

stefnotch commented Jan 19, 2024

Will we need a MathML equivalent of this?

The MathML core spec specifies a few global attributes.

@ealmloff
Copy link
Member

ealmloff commented Jan 19, 2024

Will we need a MathML equivalent of this?

The MathML core spec specifies a few global attributes.

Yes, we should also change

impl SvgAttributes for $name {}

To apply svg global attributes only to the svg namespace instead of every namespaced element

@Ameyanagi
Copy link
Contributor Author

@stefnotch @ealmloff
I will try to add the global attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants