Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using cargo.toml version #1813

Merged
merged 1 commit into from
Jan 11, 2024
Merged

using cargo.toml version #1813

merged 1 commit into from
Jan 11, 2024

Conversation

hem1t
Copy link
Contributor

@hem1t hem1t commented Jan 11, 2024

  • Replaced CFG_RELEASE with CARGO_PKG_VERSION
  • No rerun on CFG_RELEASE

@hem1t
using cargo.toml version
0bb075f 
- Replaced `CFG_RELEASE` with `CARGO_PKG_VERSION`
- No rerun on `CFG_RELEASE`
@jkelleyrtp
Copy link
Member

Hey! Thanks for the PR. This seems correct - but I'm not sure where our cfg_release var is coming from. @ealmloff do you know?

@hem1t
Copy link
Contributor Author

hem1t commented Jan 11, 2024

@ealmloff said that it is manually defined and now we don't use it and they said check with Jon if they need POKE_RA_DEVS=1 anymore

@jkelleyrtp
Copy link
Member

Ah, yeah, the poke RA devs comes from some very old issues. This is good then - thanks!

@ealmloff
Copy link
Member

ealmloff commented Jan 11, 2024 •
edited
Loading

I'm not sure where cfg_release was coming from, but this seems better. This will close #1739

@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program labels Jan 11, 2024
@ealmloff ealmloff merged commit 8be9a71 into DioxusLabs:master Jan 11, 2024
10 checks passed
@ealmloff ealmloff mentioned this pull request Jan 11, 2024
Closed
3 tasks
@hem1t hem1t deleted the fix-cli-version branch January 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cli Related to the dioxus-cli program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hem1t @jkelleyrtp @ealmloff