Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoformat ignores files in .gitignore #1704

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Autoformat ignores files in .gitignore #1704

merged 7 commits into from
Dec 13, 2023

Conversation

Exotik850
Copy link
Contributor

Fixes 1520

ealmloff
ealmloff approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed is_target_dir to not ignore paths like /src/target/windows. Other than that it looks good. Thank you!

@ealmloff ealmloff merged commit 1ec230a into DioxusLabs:master Dec 13, 2023
@mrxiaozhuox mrxiaozhuox mentioned this pull request Feb 6, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealmloff ealmloff ealmloff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dx fmt should skip gitignored files
2 participants
@Exotik850 @ealmloff