Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename IntoDynNode and IntoTemplate traits #1624

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Erithax
Copy link
Contributor

@Erithax Erithax commented Nov 9, 2023

From

pub trait IntoDynNode<'a, A = ()> {
    fn into_vnode(self, cx: &'a ScopeState) -> DynamicNode<'a>;
}
pub trait IntoTemplate<'a> {
    fn into_template(self, _cx: &'a ScopeState) -> VNode<'a>;
}

to

pub trait IntoDynNode<'a, A = ()> {
    fn into_dyn_node(self, cx: &'a ScopeState) -> DynamicNode<'a>;
}
pub trait IntoVNode<'a> {
    fn into_vnode(self, _cx: &'a ScopeState) -> VNode<'a>;
}

Tested by compiling and serving my Dioxus project

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This naming scheme is much more clear, thank you!

(Waiting for a second review and the next release before merging this because it is a breaking change)

@ealmloff ealmloff added core relating to the core implementation of the virtualdom breaking This is a breaking change labels Nov 9, 2023
@jkelleyrtp jkelleyrtp merged commit c1d9553 into DioxusLabs:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change core relating to the core implementation of the virtualdom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants