Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: props spread #1349

Merged
merged 32 commits into from
Jan 8, 2024
Merged

feat: props spread #1349

merged 32 commits into from
Jan 8, 2024

Conversation

atty303
Copy link
Contributor

@atty303 atty303 commented Aug 13, 2023

(I'll write more details later.)

fixes #1179

@ealmloff ealmloff added enhancement New feature or request html Related to the html crate core relating to the core implementation of the virtualdom labels Aug 17, 2023
@ealmloff ealmloff added this to the 0.5 Release milestone Sep 20, 2023
@ealmloff ealmloff added the breaking This is a breaking change label Sep 22, 2023
@tigerros
Copy link

This would be really useful for #1483

@ealmloff ealmloff marked this pull request as ready for review September 27, 2023 15:13
@ealmloff
Copy link
Member

ealmloff commented Sep 27, 2023

This should be working now with a few caveats:

  • The builder macro is getting very large. It works, but it is difficult to change. We should pull it out into multiple files. Because this PR unblocks a UI toolkit, I don't think this should be changed in this PR. I can refactor the macro in a new PR
  • This PR does not handle overlapping attributes between elements you extend (eg. input and global attribute both have a width attribute). We need some form of specialization here. We also need an owned version to the builder. Deref specialization only gives you an immutable reference to the object. I remember some marker trait based specialization, but I can't find the article now. Any ideas here would be appreciated!

Matthunz pointed out https://github.com/search?q=repo%3Alinebender%2Fxilem+viewmarker&type=code might be useful here?

@ealmloff ealmloff mentioned this pull request Nov 17, 2023
@atty303
Copy link
Contributor Author

atty303 commented Jan 7, 2024

@ealmloff
I don't have enough time to contribute now, so I'll leave the rest to you. Thanks and sorry.

@jkelleyrtp jkelleyrtp merged commit 4fc2802 into DioxusLabs:master Jan 8, 2024
8 of 10 checks passed
@jkelleyrtp
Copy link
Member

@atty303 Thanks for the PR! Excited to get this out in 0.5!

@atty303 atty303 deleted the issue-1179 branch February 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change core relating to the core implementation of the virtualdom enhancement New feature or request html Related to the html crate
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Extensible Element & EventHandler generics
4 participants