Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[component] macro should allow manual props #1938

Closed
jkelleyrtp opened this issue Feb 14, 2024 · 0 comments · Fixed by #2105
Closed

#[component] macro should allow manual props #1938

jkelleyrtp opened this issue Feb 14, 2024 · 0 comments · Fixed by #2105
Assignees
@jkelleyrtp
Labels
tweak Small changes to improve experience
Milestone
0.5.0: Signals

Comments

@jkelleyrtp
Copy link
Member

Request

It would be useful if, when a component manually specifies its props with a field called props, we allowed that component to retain the #[component] annotation. Eventually we want to overload the #[component] macro with more functionality (like storybook, mocking, etc) so having this as an option would retain some consistency.
@jkelleyrtp jkelleyrtp added the tweak Small changes to improve experience label Feb 14, 2024
@jkelleyrtp jkelleyrtp self-assigned this Mar 18, 2024
@jkelleyrtp jkelleyrtp mentioned this issue Mar 18, 2024
Merged
1 task
jkelleyrtp added a commit that referenced this issue Mar 18, 2024
@jkelleyrtp
Merge pull request #2105 from DioxusLabs/jk/props-expand
468d2b6 
Fix #1938, allow explicit props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkelleyrtp jkelleyrtp

Labels
tweak Small changes to improve experience
Projects
None yet
Milestone
0.5.0: Signals
Development

Successfully merging a pull request may close this issue.

Fix #1938, allow explicit props DioxusLabs/dioxus
1 participant
@jkelleyrtp