Props spreading causes an infinite loop

[atty303]

Problem

dioxus/packages/core/src/diff.rs

Lines 144 to 163 in 5b6f9d6

	match (left_iter.peek(), right_iter.peek()) {
	(Some(left), Some(right)) => {
	// check which name is greater
	match left.name.cmp(right.name) {
	std::cmp::Ordering::Less => self.remove_attribute(
	left.name,
	left.namespace,
	mounted_id,
	),
	std::cmp::Ordering::Greater => self.write_attribute(
	right_template,
	right,
	idx,
	mounted_id,
	),
	std::cmp::Ordering::Equal => {
	self.diff_attribute(left, right, mounted_id)
	}
	}
	}

It appears that the iterator is not consumed when it enters this case.
I tried calling left_iter.next() right_iter.next() and the infinite loop was resolved.
Is this the right way to fix it?

Environment:

• Dioxus version: master
• Rust version: 1.75.0]
• OS info: Windows
• App platform: web

Questionnaire

• I'm interested in fixing this myself but don't know where to start
• I would like to fix and I have a solution, but I don't know how to test it.
• I don't have time to fix this right now, but maybe later

[atty303]

Component definitions are here:
https://github.com/atty303/bb2-building/blob/63d99f345f604020143ede9b9cda4f5f93106c61/src/components/tabs.rs

Here is what we use:
https://github.com/atty303/bb2-building/blob/63d99f345f604020143ede9b9cda4f5f93106c61/src/components/skill_view.rs#L71-L128

[ealmloff]

Yes, the item should be consumed in each of those branches.

You can test the fix by trying to diff two spread attributes with a different number of attributes (both small -> large and large -> small)