Do not call save() when processing order item #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling save() causes the order ID to return 0 (or sometimes `null`) in the `woocommerce_new_order_item` action hook if the priority is too low. This has caused a compatibility issue with plugins that rely on the order ID to be available. Since the save() is not necessary when processing order items (it is however required for orders), we can safely remove it. Furthermore, we don't need to call `update_meta_data` since the order line is only added once. Instead `add_meta_data` suffices. Tested w/wo HPOS.
mntzrr
requested review from
MichaelBengtsson
and removed request for
NiklasHogefjord
MichaelBengtsson
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling save() causes the order ID to return 0 (or sometimes
null) in thewoocommerce_new_order_itemaction hook if the priority is too low. This has caused a compatibility issue with plugins that rely on the order ID to be available.Since the save() is not necessary when processing order items (it is however required for orders), we can safely remove it.
Furthermore, we don't need to call
update_meta_datasince the order line is only added once. Insteadadd_meta_datasuffices.Tested w/wo HPOS.
https://app.clickup.com/t/86955260q