Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese Localization #136

Merged
merged 1 commit into from
May 28, 2020

Conversation

mimikun
Copy link
Contributor

@mimikun mimikun commented May 14, 2020

This is Draft.

@Dimillian
Copy link
Owner

If you merge master with your branch you'll have items in japanese now :)
50baff3

Screenshot 2020-05-14 at 16 02 40

@mimikun mimikun force-pushed the add/japanese-localization branch 4 times, most recently from f0a903f to fd107f2 Compare May 21, 2020 06:44
@Dimillian
Copy link
Owner

This is really awesome progress. Can't wait to ship it in an update :)

@mimikun mimikun force-pushed the add/japanese-localization branch 5 times, most recently from 0065f59 to bc56895 Compare May 28, 2020 13:42
@mimikun mimikun force-pushed the add/japanese-localization branch from bc56895 to 0ab65eb Compare May 28, 2020 13:49
@mimikun mimikun marked this pull request as ready for review May 28, 2020 13:53
@mimikun
Copy link
Contributor Author

mimikun commented May 28, 2020

Thank you for waiting.

There is an untranslated part, but I was unsure of the nuances, so I skipped it.

@Dimillian
Copy link
Owner

Perfect :) I'll try to notify you of the missing keys. Will be in the next update! Could you also take a look at the App Store metas? If we could have the App Store description / subtitle translated it would have a big impact on your App Store :) https://github.com/Dimillian/ACHNBrowserUI/tree/master/app-store/metada

@Dimillian Dimillian merged commit c48e8f4 into Dimillian:master May 28, 2020
@Dimillian Dimillian mentioned this pull request May 28, 2020
11 tasks
@mimikun
Copy link
Contributor Author

mimikun commented May 28, 2020

Thanks! I'll try AppStore metadata translate.
Would you tell me how to preview AppStore metadata ?
It's difficult to translate if you don't know how it actually looks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants