Interdependent items builder #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new interdependent builder has been added to construct a more efficient, complex GroupedListView where the current element is dependent on its neighboring elements.
Dart SDK increased from version 2.12 to 2.17 due to new functionalities only available for the new version.
The chat example app has been upgraded to include a more realistic implementation of a chat timeline, utilizing the new interdependent builder. Additionally, an infinite timeline feature was added to test the performance of the new method.
I added a test case to verify that the previous, current, and next elements are delivered in the expected order, in various list sizes and sort orders.
kristofb
reviewed
Jan 29, 2023
lib/grouped_list.dart
Outdated
| @@ -358,13 +363,25 @@ class _GroupedListViewState<T, E> extends State<GroupedListView<T, E>> { | |||
| /// Returns the widget for element positioned at [index]. The widget is | |||
| /// retrieved either by [widget.indexedItemBuilder] or [widget.itemBuilder]. | |||
| Widget _buildItem(context, int index) { | |||
| final int elementsLength = _sortedElements.length; | |||
There was a problem hiding this comment.
Useless to declare it as a variable, just use _sortedElements.length in the one place needed
There was a problem hiding this comment.
I also did the same thing for the variables key and value for the same reason.
Changed requested
Changed realized to reduce the number of operation inside _buildItem method
Commentary updated
|
Thank you for your contribution, lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to difficulties implementing a chat app using the
GroupedListViewwidget with the currentitemBuilderandindexedItemBuildermethods, I added a new builder calledinterdependentItemBuilderto construct the items while bringing in the previous, current, and next elements on each step, resulting in better performance.I also added:
interdependentItemBuildermethod.Here is a print screen of the new Chat Example App: