Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fail to decode red packet payload on mobile on twitter #1865

Closed
2 of 10 tasks
jk234ert opened this issue Nov 9, 2020 · 2 comments
Closed
2 of 10 tasks

[Bug] Fail to decode red packet payload on mobile on twitter #1865

jk234ert opened this issue Nov 9, 2020 · 2 comments
Assignees

Comments

@jk234ert
Copy link
Contributor

jk234ert commented Nov 9, 2020

Bug Report

Environment

System

  • Windows

    • OS Version:
  • Mac OS X

    • OS Version:
  • Linux

    • Linux Distribution:
    • OS Version:

Platform/Browser

  • Chrome

    • Maskbook Version:
    • Browser Version:
  • Firefox

    • Maskbook Version:
    • Browser Version:
  • Android

    • Maskbook Version:
    • Android Version:
  • iOS

    • Maskbook Version:
    • iOS Version:

Build Variant

  • Where do you get Maskbook?
    • Store
    • ZIP
    • Self-Compiled
      • Build Commit: /Optionally attach a Commit ID, if it is from an pre-release branch head/

Bug Info

This issue is not reproducible on previous version (1.18.2)

Create a redpacket on rinkeby, then check the post, there is error message with "Maskbook has an error" as below screenshot.

  1. Send redpackets from mobile app or Chrome/Firefox, on Chrome/Firefox everything works properly
  2. Send redpackets from mobile app or Chrome/Firefox, on mobile the issue occurs at 100%.

So this issue should be related to the redpacket plugin view injection on the mobile app Twitter.

Actual Behavior

/What happened?/
Simulator Screen Shot - iPhone 12 Pro Max - 2020-11-09 at 09 28 42

@Jack-Works
Copy link
Member

@jk234ert iOS only?

@guanbinrui
Copy link
Member

guanbinrui commented Nov 9, 2020

This issue caused by eval used in the template function provided by lodash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants