Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker-compose.yml way of installing #994

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

RexYuan
Copy link
Contributor

@RexYuan RexYuan commented Jun 25, 2024

I added a docker compose file example to the documentation. Note that the thumbnail directory bind mount is necessary because if it wasn't there already and the content folder isn't writable, it will fail to mkdir the thumb /content/thumb.

I added a docker compose file example to the documentation. Note that the thumbnail directory bind mount is necessary because if it wasn't there already and the content folder isn't writable, it will fail to mkdir the thumb /content/thumb.
@Difegue
Copy link
Owner

Difegue commented Jun 26, 2024

👋 Were you aware of the compose file already located at https://github.com/Difegue/LANraragi/blob/dev/tools/build/docker/docker-compose.yml ? I wonder if this doc change shouldn't mention this file instead.

I think I'll add this extra volume to the main dockerfiles though, we had some discussions about it recently over at #953.

@RexYuan
Copy link
Contributor Author

RexYuan commented Jun 26, 2024

Thanks for updating the Dockerfile! As for the dev environment docker-compose.yml, I think it's okay to not mention it here because people won't need it for a simple user setup. Additionally, the first time I found this project I did a search of "docker-compose" in the doc site and the first thing it showed was that file and it was sorta confusing since I wasn't expecting to be reading about the dev environment the first time setting the project up

@siliconfeces
Copy link
Contributor

Yeah that compose file is mostly useful for developers, or if you are peculiar about your container setup and want to keep redis separate.

@Difegue
Copy link
Owner

Difegue commented Jun 27, 2024

Yeah, I suppose it makes sense to include a simple one in the doc. Works for me!

@Difegue Difegue merged commit bd0b2d7 into Difegue:dev Jun 27, 2024
Copy link

holopin-bot bot commented Jun 27, 2024

Congratulations @RexYuan, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/clxxs2jlc09080dldyw0ywm5w

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants