Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file upload permissions #1106

Closed
wants to merge 1 commit into from

Conversation

psilabs-dev
Copy link
Contributor

Currently when the LRR docker image is run, the contents folder is where archives are saved, and any file uploads will fail due to a lack of permission bc the contents folder in docker is not owned by koyomi. This commit rectifies that.

Checking 01-lrr-setup I saw that permfixes were applied but only to thumb, I'm not sure why only the thumb folder is checked. I could be missing something here

@Difegue
Copy link
Owner

Difegue commented Nov 4, 2024

This was an intentional choice as some users don't trust the server to not tamper with their files, so the docker setup is made to technically work with a read-only content folder.

Now this obviously makes file uploads, downloads and deletion from the server not work, but this was considered an OK tradeoff at the time.

Auto-changing permissions on the thumbnail folder itself is fine, since that's not meant to contain user data. (And if we move on with completely separating it from the content folder instead of the weird double mount situation that's currently in place, this bit of script will make more sense I think)

@psilabs-dev
Copy link
Contributor Author

Ok, I'll close this, given this is intended behavior

@psilabs-dev psilabs-dev closed this Nov 4, 2024
@psilabs-dev psilabs-dev deleted the fix-content-permissions branch November 7, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants