Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces named parameters for the plugins while maintaining backwards compatibility.
It should also allow for conversion of existing parameters without losing the configuration.
To help you in the review, basically
get_plugin_parameters()
now return an hash instead of an array.It can be feed directly to the new plugins entry point, but, for the old plugins, it contains the key
customargs
with the array of values from the DB.The choice of what to use is made inside the
exec_*_plugin
subs.Some issues I want to point out:
$lrr_info
and$params
can be merged, but this requires adding checks to avoid collisions between the names of internal keys and those chosen by the plugin contributors. Alternatively you could change the names of the "internal" keys (eg:archive_id
to_archive_id
), but this will break the compatibility.oneshot_param
is now duplicated in$params
as$params->{'oneshot'}
because I think it should be moved there if we keeps the two hashes separated.