Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rating option on contextMenu #1079

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Added Rating option on contextMenu #1079

merged 2 commits into from
Oct 13, 2024

Conversation

Hanga7yr
Copy link
Contributor

@Hanga7yr Hanga7yr commented Sep 22, 2024

Added a rating option on the contextMenu.

When an option is selected it updates the tags of the selected archive and add or modifies the rating tag to the selected stars.
if selected the white one, it will remove the rating tag.

Just made it in a few hours so it's probably not really good but it's a start.
Changes are only client side and doesn't need many more things done unless the rating is added to the archive thumb view.

Signed-off-by: hanga7yr <hanga7yr@pm.me>
@Hanga7yr
Copy link
Contributor Author

Adds functionality requested on #873

Copy link
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this AI-generated code? I'm afraid there are quite a few logic errors...

I did get it to work after a few tweaks though, so I believe this can still be salvaged.

public/js/index.js Outdated Show resolved Hide resolved
templates/index.html.tt2 Outdated Show resolved Hide resolved
public/js/index.js Outdated Show resolved Hide resolved
public/js/index.js Outdated Show resolved Hide resolved
public/js/index.js Show resolved Hide resolved
public/js/index.js Outdated Show resolved Hide resolved
public/js/server.js Outdated Show resolved Hide resolved
public/js/index.js Outdated Show resolved Hide resolved
@Hanga7yr
Copy link
Contributor Author

Hanga7yr commented Sep 29, 2024

Hi,
No, it was not AI, however, now that I look around better, there seems to be some changes that are not reflected on the commit.
It must have been me tweaking around as I did have some problems cleaning up the commit, because most changes you point I believe I encountered too.

I will try to have a proper update soon. Sorry to have you waste time looking at this mess.
I will, however, use LRR.splitTagsByNamespace(data.tags) now that I know of it.

@Difegue
Copy link
Owner

Difegue commented Sep 29, 2024

Ah, apologies for the false accusation in that case. 🙇
There's no problem having multiple commits in the PR for cleanup if necessary, we can just squash things in the end. 🤠

Good luck!

Added an actual improvement regarding tags parsing and the subsequent modifications to utilize it.
Added refresh once a rating has been selected.

Signed-off-by: hanga7yr <hanga7yr@pm.me>
@Hanga7yr
Copy link
Contributor Author

Ah, apologies for the false accusation in that case. 🙇 There's no problem having multiple commits in the PR for cleanup if necessary, we can just squash things in the end. 🤠

Good luck!

I uploaded a fix of the commit, it resolves most of the problems while adding the improvement of LRR.splitTagsByNamespace(data.tags).
It didn't take long as it was something I already did.
The only thing that I couldn't really fix was removing the API call.

Hope everything is alright now.

Copy link
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Sorry for the delay in re-reviewing this.

@Difegue Difegue merged commit 48651c3 into Difegue:dev Oct 13, 2024
1 check passed
@Difegue
Copy link
Owner

Difegue commented Oct 13, 2024

Using the blank star emoji for "no rating/remove rating" is a bit odd so I might tweak that later, but the base featureset is good. Thanks!

Copy link

holopin-bot bot commented Oct 13, 2024

Congratulations @Hanga7yr, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm281xeqf103270cl5ehxvpczs

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@Hanga7yr Hanga7yr deleted the rating branch October 14, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants