-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Rating option on contextMenu #1079
Conversation
Signed-off-by: hanga7yr <hanga7yr@pm.me>
Adds functionality requested on #873 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this AI-generated code? I'm afraid there are quite a few logic errors...
I did get it to work after a few tweaks though, so I believe this can still be salvaged.
Hi, I will try to have a proper update soon. Sorry to have you waste time looking at this mess. |
Ah, apologies for the false accusation in that case. 🙇 Good luck! |
Added an actual improvement regarding tags parsing and the subsequent modifications to utilize it. Added refresh once a rating has been selected. Signed-off-by: hanga7yr <hanga7yr@pm.me>
I uploaded a fix of the commit, it resolves most of the problems while adding the improvement of Hope everything is alright now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Sorry for the delay in re-reviewing this.
Using the blank star emoji for "no rating/remove rating" is a bit odd so I might tweak that later, but the base featureset is good. Thanks! |
Congratulations @Hanga7yr, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm281xeqf103270cl5ehxvpczs This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Added a rating option on the contextMenu.
When an option is selected it updates the tags of the selected archive and add or modifies the rating tag to the selected stars.
if selected the white one, it will remove the rating tag.
Just made it in a few hours so it's probably not really good but it's a start.
Changes are only client side and doesn't need many more things done unless the rating is added to the archive thumb view.