Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal Headers and Compression #191

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Signal Headers and Compression #191

merged 13 commits into from
Jan 23, 2025

Conversation

MJHC
Copy link
Contributor

@MJHC MJHC commented Jan 22, 2025

I have added:

  • TLS flag for ease of analysis
  • disconnect method to client struct in client code
    • server will no longer complain about clients disconnection without saying goodbye
  • Signal layer for client for manual gzip decompression and signal headers
  • Signal headers for websocket on client
    • needs to be refactored when this feature has been implemented.
  • signal timestamp on server
  • more accurate CORS
  • Changed ports to actual http/s ports, linux users can just change them if they dont want to sudo

closes #182, closes #184, closes #189

Darkros1245
Darkros1245 previously approved these changes Jan 23, 2025
Darkros1245
Darkros1245 previously approved these changes Jan 23, 2025
Comment on lines +17 to +18
HTTPS_PORT=443
HTTP_PORT=80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doens't work on linux

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you sudo it does

@@ -271,28 +277,28 @@ impl<T: ClientDB, U: SignalServerAPI> Client<T, U> {

let timestamp = SystemTime::now();

// Update the contact.
let to = match self.contact_manager.get_contact(service_id) {
/*// Update the contact.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

@MJHC MJHC merged commit 2cdbb42 into main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client sometimes receives ws error send_message should only take alias encoding should be gzip
4 participants