#639: Feature: BITFIELD command with all subcommands #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvyadav1111
changed the title
apoorvyadav1111
force-pushed
the
feat/bitfield
branch
from
553e9d1 to
c547531
Compare
apoorvyadav1111
changed the title
iamskp11
reviewed
Sep 28, 2024
apoorvyadav1111
force-pushed
the
feat/bitfield
branch
from
f5b9667 to
0312ffc
Compare
|
Hi team, @JyotinderSingh , @lucifercr07 , @AshwinKul28 , PR is rebased with the master, Could you please review at your convenience? |
✅ Deploy Preview for dicedb-docs2 canceled.
|
|
@apoorvyadav1111 please fix the build once. |
Hi @lucifercr07, thanks for reruning the pipeline. It passed this time. I am trying to recreate the issue in the local meanwhile. |
JyotinderSingh
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Thanks for the contributions @apoorvyadav1111! The changes look good and well tested!
JyotinderSingh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #639
Implemented
BITFIELD key [SUBCOMMAND]. Have handled predominantly most test cases present in the redis tcl tests. implemented unit test cases.Additionally, added *.rdb in .gitignore to avoid pushing rdb files to git.
Design:
Added utility functions in ByteArray struct to handle get set and incrby commands.
All test cases pass. Once merged #640 can be unblocked.
Thanks
Apoorv