fix: log error messages instead of values #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AshwinKul28 @lucifercr07 could you please take a look at this? essentially we were logging error values and not from |
KaviiSuri
force-pushed
the
kavii/fix-log-error-message
branch
from
3303af9 to
07ed972
Compare
KaviiSuri
force-pushed
the
kavii/fix-log-error-message
branch
from
07ed972 to
01e6f96
Compare
lucifercr07
approved these changes
Sep 22, 2024
hash-f
pushed a commit
to hash-f/dice
that referenced
this pull request
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #685
Problem
The new logger missed handling conversion of err values to the messages.
Old Output
New Output