Fix getex command returning value for json based object #674
Conversation
|
yea sure, done. |
JyotinderSingh
requested review from
JyotinderSingh and
apoorvyadav1111
and removed request for
apoorvyadav1111 and
JyotinderSingh
| name: "GetEx with key holding SET type", | ||
| commands: []string{"SADD KEY 1 2 3", "GETEX KEY"}, | ||
| expected: []interface{}{"OK", "WRONGTYPE Operation against a key holding the wrong kind of value"}, | ||
| assert_type: []string{"equal", "equal"}, |
There was a problem hiding this comment.
Hi, the test is failing as you are not deleting key with name KEY before executing an SADD command. Please add a delete command for KEY. please see line 151 for reference.
There was a problem hiding this comment.
incorporated. I have changed key name. Ideally, tests should be independent.
|
@apoorvyadav1111 @JyotinderSingh could u please check this PR. |
|
Hi @kapishmalik , I have reviewed the PR. I will not be merging it as I don't have permission to do so. One of the collaborators will pick this PR up as per their schedule. |
…returning-value-for-json-based-object
|
@JyotinderSingh could you please run the tests in workflow and merge this PR. |
…returning-value-for-json-based-object
|
@lucifercr07 @JyotinderSingh @apoorvyadav1111 can you please run tests in workflow and merge this PR as I need to resolve conflicts and merge master in this branch. |
|
@JyotinderSingh below failure is not related to my change. Can you please help here? --- FAIL: TestServerRestartAfterAbort (1.00s) |
I've retriggered the tests |
|
Thanks, we are good to merge this PR. |
There was a problem hiding this comment.
Thanks for the fix @kapishmalik. Thanks for the reviews @apoorvyadav1111. Approved.
kapishmalik
deleted the
ISSUE625-fix-getex-returning-value-for-json-based-object
branch
This PR resolves #625.
DiceDB CLI screenshot:
Integration test screenshot:
UTs screenshot:
