Refactor the code to separate out the store package #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumya-codes
force-pushed
the
soumyap/refactor-store-code
branch
2 times, most recently
from
1b6c38d to
d0c24e6
Compare
|
Going through it, just a general comment, can we make |
Can I do that in the subsequent PRs? There are a lot of areas of improvement to be done in naming... |
soumya-codes
changed the title
JyotinderSingh
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks for this massive effort @soumya-codes! The changes look really well thought out.
Have left one minor comment.
Signed-off-by: soumya-codes <151079203+soumya-codes@users.noreply.github.com>
soumya-codes
force-pushed
the
soumyap/refactor-store-code
branch
from
d0c24e6 to
fbc31c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first major in the many set of refactoring PRs required for moving DiceDB to multithreading.
This PR refactors the existing code by doing the following:
Note: There is lot of movement of code and takes a lot of effort to rebase and verify changes in this PR so there are couple of requests from my side:
DO NOTmerge any further PRs till this PR is merged.cc @JyotinderSingh @lucifercr07 @AshwinKul28 @pratikpandey21