Add OSX Support #41
Merged
Add OSX Support #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further going on, it seems like there will be code duplication among the darwin and Linux go files. Common code needs to be moved to async_tcp.go wherever possible. ~ Scope of improvement here. @arpitbbhayani |
arpitbbhayani
requested changes
Oct 19, 2022
arpitbbhayani
approved these changes
Oct 19, 2022
|
This is big!!! 🐝 Thank you so much 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue:- #22. Added OSX Compatibility
Have verified and tested the implementation on Macbook Pro 2018 ( Amd64 )
Shall run on Arm-based Chips ( M1 and further ) as well given that the OS exposes the same KQueue API.