Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making all file descriptors non-blocking #30

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Making all file descriptors non-blocking #30

merged 1 commit into from
Oct 18, 2022
+1 −1

Conversation

asutosh97
Copy link
Contributor

Because of typo, we were accidentally setting the server file descriptor to non blocking again and again

@asutosh97
For all client connections, set the file descriptor to be non-blockin…
9f20180 
…g so that any blocking operation errors out

Because of typo, we were accidentally setting the server file descriptor to non blocking again and again
@arpitbbhayani arpitbbhayani merged commit 97dd4e9 into DiceDB:master Oct 18, 2022
@arpitbbhayani
Copy link
Contributor

Thanks a ton @asutosh97 🍺

@arpitbbhayani arpitbbhayani changed the title For all client connections, set the file descriptor to be non-blocking so that any blocking operation errors out Making all file descriptors non-blocking Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpitbbhayani arpitbbhayani arpitbbhayani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asutosh97 @arpitbbhayani