Reset datastores before every benchmark test #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review @JyotinderSingh |
JyotinderSingh
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Thanks for the quick debug and fix @gauravsarma1992 and @AshwinKul28!
kushal0511-not
pushed a commit
to kushal0511-not/dice
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue of constant high memory usage when running
go test -bench=. -test.benchmem executerbechmark_test.go.The memory allocated to a map grows as and when you start storing data in it. When you delete data from a map, Go doesn't automatically free up the memory and keeps it allocated to the map. So when the next set of Benchmarking tests ran, it reused some of the deleted memory and the memory footprint remained the same as the last benchmark test with the high number of keys.
In order to actually free the occupied memory and allocate a new block of memory, this PR initialises the data stores in the store.go before running every benchmark test. Looks like the memory footprint reduces again before every benchmark test.
https://discord.com/channels/1034342738960855120/1264145943884992595/1271153754410061927