Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#222: Added Benchmark for negative number and close to MinInt64, MaxInt64 #230

Merged
merged 5 commits into from
Aug 4, 2024
Merged

#222: Added Benchmark for negative number and close to MinInt64, MaxInt64 #230

merged 5 commits into from
Aug 4, 2024

Conversation

Vsareen0
Copy link
Contributor

@Vsareen0 Vsareen0 commented Aug 4, 2024

  • Added benchmark for negative numbers and number close to MinInt64, MaxInt64
=== RUN   BenchmarkMinMaxEncodeDecodeInt
BenchmarkMinMaxEncodeDecodeInt
BenchmarkMinMaxEncodeDecodeInt-12       49743938                23.24 ns/op            7 B/op          1 allocs/op
PASS
ok      github.com/dicedb/dice/core/dencoding   1.396s

@Vsareen0
Copy link
Contributor Author

Vsareen0 commented Aug 4, 2024

Hey @JyotinderSingh / @arpitbbhayani this test case is failing the build, I have verified on local, TestDecodeOneNoDataRead this one causes build to fail. if I comment this out, works expected !

@JyotinderSingh
Copy link
Collaborator

Hey @JyotinderSingh / @arpitbbhayani this test case is failing the build, I have verified on local, TestDecodeOneNoDataRead this one causes build to fail. if I comment this out, works expected !

Fixed, please rebase.

@Vsareen0
Copy link
Contributor Author

Vsareen0 commented Aug 4, 2024

Thanks for quick resolution @JyotinderSingh !

@JyotinderSingh
Copy link
Collaborator

I updated the benchmark structure a little for this file, could you please take a look at accordingly move this function into dencoding_benchmark_test.go?

@Vsareen0
Copy link
Contributor Author

Vsareen0 commented Aug 4, 2024

Thanks for guidance @JyotinderSingh , looks much cleaner now !

JyotinderSingh
JyotinderSingh approved these changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@JyotinderSingh JyotinderSingh merged commit 3a912f8 into DiceDB:master Aug 4, 2024
2 checks passed
SyedMa3 pushed a commit to SyedMa3/dice that referenced this pull request Aug 5, 2024
@Vsareen0 @SyedMa3
DiceDB#222: Added Benchmark for negative number and close to MinInt64…
c04d03f 
…, MaxInt64 (DiceDB#230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JyotinderSingh JyotinderSingh JyotinderSingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vsareen0 @JyotinderSingh