Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#198: Adding unit tests for eval.go file #210

Merged
merged 3 commits into from
Aug 11, 2024
Merged

#198: Adding unit tests for eval.go file #210

merged 3 commits into from
Aug 11, 2024

Conversation

lucifercr07
Copy link
Contributor

  • Adding unit tests for eval.go file
  • Few test cases are blocked due to GH-201, would update once issue is resolved.

@lucifercr07
Copy link
Contributor Author

@JyotinderSingh @yashs360 please review once.

yashs360
yashs360 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@yashs360 yashs360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks for contributing

@JyotinderSingh
Copy link
Collaborator

Could you please rebase on latest master and resolve the conflicts?

@lucifercr07 lucifercr07 force-pushed the lucifercr07/GH-198_unit_test_eval_file branch from 9885ba8 to de35337 Compare August 8, 2024 19:05
@lucifercr07
Copy link
Contributor Author

lucifercr07 commented Aug 8, 2024 •
edited
Loading

@JyotinderSingh please review once have rebased the branch, and edited some new test case to maintain parity with testCase struct.

JyotinderSingh
JyotinderSingh requested changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for adding all these tests, have left a few small coments.

core/eval_test.go Outdated Show resolved Hide resolved
core/eval_test.go Outdated Show resolved Hide resolved
core/eval_test.go Outdated Show resolved Hide resolved
core/eval_test.go Show resolved Hide resolved
@JyotinderSingh JyotinderSingh changed the title feat: [GH-198] Adding unit tests for eval.go file #198: Adding unit tests for eval.go file Aug 10, 2024
JyotinderSingh
JyotinderSingh approved these changes Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Approved.

@JyotinderSingh JyotinderSingh merged commit 5416a77 into DiceDB:master Aug 11, 2024
2 checks passed
lucifercr07 added a commit to lucifercr07/dice that referenced this pull request Aug 16, 2024
@lucifercr07
DiceDB#198: Adding unit tests for eval.go file (DiceDB#210)
547a523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JyotinderSingh JyotinderSingh JyotinderSingh approved these changes

@yashs360 yashs360 yashs360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucifercr07 @JyotinderSingh @yashs360