Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support KEYS command #197

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

mingo023
Copy link
Contributor

@mingo023 mingo023 commented Aug 2, 2024

This PR aims to support KEYS command like redis KEYS

Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, left a few minor comments.

@mingo023 mingo023 force-pushed the feat/support-keys-command branch from f878742 to 4f26ee7 Compare August 5, 2024 09:13
@mingo023
Copy link
Contributor Author

mingo023 commented Aug 5, 2024

Hi @JyotinderSingh, Thanks for your feedbacks. I've updated my PR to optimize and enhance test cases

@JyotinderSingh JyotinderSingh self-requested a review August 5, 2024 09:34
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for the KEYS command, the changes look good. Merging!

@JyotinderSingh JyotinderSingh merged commit c72f2a7 into DiceDB:master Aug 5, 2024
2 checks passed
@mingo023 mingo023 deleted the feat/support-keys-command branch August 6, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants