Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated EXISTS command to IronHawk engine #1447

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

n4vxn
Copy link
Contributor

@n4vxn n4vxn commented Feb 5, 2025

No description provided.


var cEXISTS = &DiceDBCommand{
Name: "EXISTS",
HelpShort: "Returns the number of keys existing in the db",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short help does not seem apt.

var count int64
for _, key := range c.C.Args {
// Check if the key exists in the store
if s.GetNoTouch(key) != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention the reason why we used GetNoTouch function in the code as a comment.

Copy link
Contributor Author

@n4vxn n4vxn Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've made the suggested changes, pls review. @arpitbbhayani

@n4vxn n4vxn force-pushed the migrate-exists-ironhawk branch from b88cca9 to b0c447f Compare February 5, 2025 13:44
@n4vxn n4vxn force-pushed the migrate-exists-ironhawk branch from b0c447f to 3d1b347 Compare February 5, 2025 13:46
@arpitbbhayani arpitbbhayani merged commit bd2de29 into DiceDB:master Feb 6, 2025
@arpitbbhayani arpitbbhayani mentioned this pull request Feb 6, 2025
4 tasks
n4vxn added a commit to n4vxn/dice that referenced this pull request Feb 7, 2025
KedarisettiSreeVamsi pushed a commit to KedarisettiSreeVamsi/dice that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants