Migrated EXISTS command to IronHawk engine #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/cmd/cmd_exists.go
Outdated
|
|
||
| var cEXISTS = &DiceDBCommand{ | ||
| Name: "EXISTS", | ||
| HelpShort: "Returns the number of keys existing in the db", |
There was a problem hiding this comment.
The short help does not seem apt.
| var count int64 | ||
| for _, key := range c.C.Args { | ||
| // Check if the key exists in the store | ||
| if s.GetNoTouch(key) != nil { |
There was a problem hiding this comment.
mention the reason why we used GetNoTouch function in the code as a comment.
There was a problem hiding this comment.
i've made the suggested changes, pls review. @arpitbbhayani
n4vxn
force-pushed
the
migrate-exists-ironhawk
branch
from
b88cca9 to
b0c447f
Compare
n4vxn
force-pushed
the
migrate-exists-ironhawk
branch
from
b0c447f to
3d1b347
Compare
4 tasks
n4vxn
added a commit
to n4vxn/dice
that referenced
this pull request
Feb 7, 2025
KedarisettiSreeVamsi
pushed a commit
to KedarisettiSreeVamsi/dice
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.