feat: port DEL command #1445
Merged
feat: port DEL command #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate DEL command to support ironhawk engine
arpitbbhayani
requested changes
Feb 4, 2025
internal/cmd/cmd_del.go
Outdated
| return cmdResNil, errWrongArgumentCount("DEL") | ||
| } | ||
|
|
||
| var count int64 |
There was a problem hiding this comment.
@arpitbbhayani wire.Response_VInt supports int64, we can either:
- convert int32 to int64 via int64(count)
- add support for int32 in cmd.proto (wire.Response_VInt32 and Response_VInt64)
There was a problem hiding this comment.
You don't need that support. The value of count does not depend on anything in the proto. You will never have massive number of keys being deleted. Change this to int
DiabolusGX
reviewed
Feb 4, 2025
n4vxn
pushed a commit
to n4vxn/dice
that referenced
this pull request
Feb 7, 2025
n4vxn
pushed a commit
to n4vxn/dice
that referenced
this pull request
Feb 7, 2025
KedarisettiSreeVamsi
pushed a commit
to KedarisettiSreeVamsi/dice
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate DEL command to support ironhawk engine.
fixes #1428