introducing linter for new code changes only #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks pass in the current PR due to no new code change. here is the verification of lint error detection for a bad change - 
|
|
Please review @arpitbbhayani @JyotinderSingh |
yashs360
commented
Jul 11, 2024
| uses: golangci/golangci-lint-action@v6 | ||
| with: | ||
| version: v1.59 | ||
| only-new-issues: true |
There was a problem hiding this comment.
This tiny flag restricts us to new code changes only.
Separate PR will be submitted for simplicity, to bulk fix all existing errors.
yashs360
commented
Jul 11, 2024
| @@ -1,4 +1,4 @@ | |||
| name: Go | |||
| name: build-and-test | |||
There was a problem hiding this comment.
Renaming this to something more descriptive.
arpitbbhayani
added a commit
that referenced
this pull request
Jul 12, 2024
Clean sweep to fix all existing lint errors. For best experience please merge this after linter PR (#136) is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding linter check for Pull requests to save some trivial review time.
Atm limited to new changes only, but can be extended to all code in future as we cleanup old lint errors.