#761: Added ZADD options implementation - XX|NX|CH|INCR| LT|GT according to Redis source code #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JyotinderSingh Can you please review the PR, thanks |
JyotinderSingh
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Thanks for this contribution @rushabhk04! This is a complicated feature with a lot of different permutations. Thanks for the exhaustive tests.
I have left a few comments.
rushabhk04
force-pushed
the
Issue761-ZADDOptions
branch
from
38e3eec to
dc4bdde
Compare
|
@JyotinderSingh , I have updated the changes. Can you please re-review it and merge it? Also, please let me know if any questions or suggestions. Thanks |
JyotinderSingh
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Thanks for working on this @rushabhk04! The changes look good.
JyotinderSingh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented Redis's option parsing for the ZADD command. Additionally, I wrote unit and integration test cases to cover the functionality.
@apoorvyadav1111 Please review this and let me know if any modifications are needed. Thank you!
I added the evaluated command logic, which handles ZADD based on option flags and operates according to the Redis source code. I also created the zset_test file for HTTP, web socket, and resp, which contains test cases for the command with various combinations of options.
Fixes #761
Closed PR related to the above #1138
The existing open PR for this issue is #1205 (the reason I have created a new PR is because of a messed up history in PR 1138).
Will put the documents in the other thread to net mess things up!
Thanks for understanding and assistance!