#1129 Add support for ZCARD #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @JyotinderSingh. This PR is to be reviewed after ZREM #1125 gets closed. |
JyotinderSingh
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Thanks for adding support for ZCARD @c-harish! The changes look good and well-tested.
There seem to be some merge conflicts, please resolve them and we can proceed with the merge.
|
Thanks for the review @JyotinderSingh. Rebased and fixed the testcases to reflect the latest http/ws responses. |
JyotinderSingh
approved these changes
Oct 29, 2024
|
Thanks for these contributions, approved. |
rushabhk04
pushed a commit
to rushabhk04/dice
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ZCARD
PR Checklist
closes #1129