-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#816 Docs : Audited Docs for Copy
command
#1140
#816 Docs : Audited Docs for Copy
command
#1140
Conversation
Copy
command
Copy
command Copy
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @onlybond , Thanks for the changes. DiceDB currently does not support databases hence the argument destination db is not being used by the server. A user can pass the parameter, It will be ignored. Therefore, please update any such reference where it is mentioned that the destination key will be updated in the destination DB.
Thanks
Hey @apoorvyadav1111 , Thanks for reviewing the PR, As you said DiceDB doesn't support databases, so in the docs should i remove all the references which are related to db? So in the parameters only 3 parameters will be given as of now? |
So you can remove references which mention that the key will be inserted in database, You can mention in the description about this. But please take that as an argument as we do take it as an argument, but just ignore it. It act as sort of placeholder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we have created referenced for documentation for easy reference and consistency which can found here: docs/command_docs_template.md and docs/sample_command_docs.md
Hi @onlybond, Hope you are well. I am eager to know more about your progress on this issue. Please reach out to me if you need any clarifications. |
hello @apoorvyadav1111 I have mentioned about the the key to be stored in another database in the notes. until diceDB supports databases its viable to mention it in the notes section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Thanks for making the changes. Please align the Error sections to the template.
Thanks,
Apoorv
hi there I have made the changes. please have a review on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one minor comment. I think we are good to go after this change
1. `WRONGTYPE Operation against a key holding the wrong kind of value`: | ||
- This error occurs if the source key holds a value that is not compatible with the `COPY` operation. | ||
2. `ERR no such key`: | ||
- This error occurs if the source key does not exist. | ||
3. `ERR target key name is busy`: | ||
- This error occurs if the destination key already exists and the `REPLACE` option is not specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. `WRONGTYPE Operation against a key holding the wrong kind of value`: | |
- This error occurs if the source key holds a value that is not compatible with the `COPY` operation. | |
2. `ERR no such key`: | |
- This error occurs if the source key does not exist. | |
3. `ERR target key name is busy`: | |
- This error occurs if the destination key already exists and the `REPLACE` option is not specified. | |
1. `Wrong type of value or key`: | |
- Error message `(error) WRONGTYPE Operation against a key holding the wrong kind of value`: | |
- This error occurs if the source key holds a value that is not compatible with the `COPY` operation. | |
2. `Not existent key`: | |
- Error message: `(error) ERR no such key` | |
- This error occurs if the source key does not exist. |
All changes done. LGTM |
This PR closes Issue : #816
Have changed the docs to be consistent and used SET Command docs for reference
Do lemme know if there are any changes to be done