-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command migration for JSON.ARRTRIM, JSON.ARRINSERT. JSON.OBJKEYS #1119
Command migration for JSON.ARRTRIM, JSON.ARRINSERT. JSON.OBJKEYS #1119
Conversation
@ayushsatyam146 we need to migrate the integration tests to the multi-threaded RESP server. In the PR description, I have added the checklist of tasks required to be completed for the migration of commands to multi-threaded RESP server. Please follow the same. |
@soumya-codes I am yet to add integration tests. I raised the PR just to show activity and give updates. I'll soon add integration tests |
Ahh, thanks for the update. In that case can you please mark the PR status as draft? |
ef8b247
to
ea8a310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayushsatyam146 can we please add websocket tests also?
Also if you can follow sample doc template and update for these commands accordingly it'd be helpful.
56975f5
to
5d34d9c
Compare
HI @ayushsatyam146 Thanks for the commendable efforts. Most of the things look great. I see the documents added for each commands are not exactly aligning with the sample documentation. Can you please make required changes to make it align so that we don't need to revisit this in the future. Thanks again. |
I'll change the docs asap |
5d34d9c
to
39c7555
Compare
Hey @ayushsatyam146, can you please look at the conflicts and rebase them with the master? Then, we will immediately merge the PR. |
39c7555
to
b0fd9c9
Compare
Hi @AshwinKul28 I fixed the conflicts. Now it is good to merge. Thanks! |
Closes #1027
Command migration for JSON.ARRTRIM, JSON.ARRINSERT. JSON.OBJKEYS