Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command migration for JSON.ARRTRIM, JSON.ARRINSERT. JSON.OBJKEYS #1119

Merged
merged 16 commits into from
Oct 28, 2024

Conversation

ayushsatyam146
Copy link
Contributor

@ayushsatyam146 ayushsatyam146 commented Oct 17, 2024

Closes #1027

Command migration for JSON.ARRTRIM, JSON.ARRINSERT. JSON.OBJKEYS

  • Migrated the evalXXX function with the latest definition
  • Update or add unit tests for the new implementation.
  • All unit tests pass successfully.
  • Ensure all integration tests pass successfully.
  • Ensure integration tests are added for the migrated command on multi-threaded resp server.
  • Move Integration tests for the respective commands under the RESP integration tests directory from Async directory
  • Please validate that the documentation for the respective commands is up to date. If not then consider adding them.
  • Add websocket integration tests

@AshwinKul28 AshwinKul28 added the migration -- command Migrates current eval to a refactored eval for all protocols functionality label Oct 17, 2024
@soumya-codes
Copy link
Contributor

soumya-codes commented Oct 17, 2024

@ayushsatyam146 we need to migrate the integration tests to the multi-threaded RESP server.

In the PR description, I have added the checklist of tasks required to be completed for the migration of commands to multi-threaded RESP server. Please follow the same.

@ayushsatyam146
Copy link
Contributor Author

@soumya-codes I am yet to add integration tests. I raised the PR just to show activity and give updates. I'll soon add integration tests

@soumya-codes
Copy link
Contributor

Ahh, thanks for the update. In that case can you please mark the PR status as draft?

@ayushsatyam146 ayushsatyam146 marked this pull request as draft October 17, 2024 07:27
@ayushsatyam146 ayushsatyam146 force-pushed the json-command-migrations branch from ef8b247 to ea8a310 Compare October 21, 2024 05:36
Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushsatyam146 can we please add websocket tests also?
Also if you can follow sample doc template and update for these commands accordingly it'd be helpful.

integration_tests/commands/async/json_test.go Show resolved Hide resolved
@ayushsatyam146 ayushsatyam146 force-pushed the json-command-migrations branch 5 times, most recently from 56975f5 to 5d34d9c Compare October 26, 2024 13:42
@ayushsatyam146 ayushsatyam146 marked this pull request as ready for review October 26, 2024 13:49
@AshwinKul28
Copy link
Contributor

HI @ayushsatyam146 Thanks for the commendable efforts. Most of the things look great. I see the documents added for each commands are not exactly aligning with the sample documentation. Can you please make required changes to make it align so that we don't need to revisit this in the future. Thanks again.

@ayushsatyam146
Copy link
Contributor Author

HI @ayushsatyam146 Thanks for the commendable efforts. Most of the things look great. I see the documents added for each commands are not exactly aligning with the sample documentation. Can you please make required changes to make it align so that we don't need to revisit this in the future. Thanks again.

I'll change the docs asap

@ayushsatyam146 ayushsatyam146 force-pushed the json-command-migrations branch from 5d34d9c to 39c7555 Compare October 27, 2024 16:03
@AshwinKul28
Copy link
Contributor

Hey @ayushsatyam146, can you please look at the conflicts and rebase them with the master? Then, we will immediately merge the PR.

@ayushsatyam146 ayushsatyam146 force-pushed the json-command-migrations branch from 39c7555 to b0fd9c9 Compare October 28, 2024 04:38
@ayushsatyam146
Copy link
Contributor Author

Hey @ayushsatyam146, can you please look at the conflicts and rebase them with the master? Then, we will immediately merge the PR.

Hi @AshwinKul28 I fixed the conflicts. Now it is good to merge. Thanks!

@lucifercr07 lucifercr07 merged commit 446d586 into DiceDB:master Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration -- command Migrates current eval to a refactored eval for all protocols functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Migration: ('JSON.ARRTRIM', 'JSON.ARRINSERTJSON.OBJKEYS')
4 participants