Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Running default make commands fails in different architecture #855

Closed
swaingotnochill opened this issue Sep 29, 2024 · 1 comment · Fixed by #856
Closed

Makefile: Running default make commands fails in different architecture #855

swaingotnochill opened this issue Sep 29, 2024 · 1 comment · Fixed by #856

Comments

@swaingotnochill
Copy link
Contributor

I am working on a MacOS arm machine and default make command fails due to hardcoded environment variables in the makefile.

Reproduce:

Run make build in any other operating system other than linux.
@swaingotnochill swaingotnochill mentioned this issue Sep 29, 2024
Merged
@swaingotnochill
Copy link
Contributor Author

@JyotinderSingh @arpitbbhayani Please review the issue and also the attached PR.

lucifercr07 added a commit that referenced this issue Sep 30, 2024
@swaingotnochill @lucifercr07
#855: Make DiceDB build work on different architectures (#856)
87f5d83 
Co-authored-by: pshubham <pshubham@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#855: Make DiceDB build work on different architectures swaingotnochill/dice
1 participant
@swaingotnochill