Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command HINCRBYFLOAT #648

Closed
arpitbbhayani opened this issue Sep 20, 2024 · 4 comments · Fixed by #853
Closed

Add support for command HINCRBYFLOAT #648

arpitbbhayani opened this issue Sep 20, 2024 · 4 comments · Fixed by #853

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the HINCRBYFLOAT command in DiceDB similar to the HINCRBYFLOAT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@ayushsatyam146
Copy link
Contributor

Can I take this issue @arpitbbhayani @JyotinderSingh

@JyotinderSingh
Copy link
Collaborator

Can I take this issue @arpitbbhayani @JyotinderSingh

Assigned

@swarajrb7
Copy link
Contributor

@arpitbbhayani Can I pick this issue?

@ayushsatyam146
Copy link
Contributor

I am posting this comment to update the status of this issue. I have implemented the basic functionality and am currently writing tests for this command. I will raise the PR in a couple of days. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants