Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command HDEL #645

Closed
arpitbbhayani opened this issue Sep 20, 2024 · 11 comments
Closed

Add support for command HDEL #645

arpitbbhayani opened this issue Sep 20, 2024 · 11 comments

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the HDEL command in DiceDB similar to the HDEL command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@HassanAarzoo
Copy link

Please assign this to me

@arpitbbhayani
Copy link
Contributor Author

@HassanAarzoo you have another one assigned to you. I will keep this one open for someone else to pick. Thanks for understanding.

@anchalsinghrajput
Copy link

Hi Arpit, can i work on this issue?

@HassanAarzoo
Copy link

@arpitbbhayani Yes its fine! Thank You

@meetghodasara
Copy link
Contributor

Hi @arpitbbhayani , can I work on this issue?

@karandixit10
Copy link
Contributor

Hi @arpitbbhayani, I can take this up if no one's working on it yet?

@manishrw
Copy link
Contributor

Hi @arpitbbhayani, Please assign this issue to me.
I've addressed the issue in the PR #678

@arpitbbhayani
Copy link
Contributor Author

Hello @manishrw,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@manishrw
Copy link
Contributor

manishrw commented Oct 7, 2024

Hey @arpitbbhayani, the PR which adds command HDEL has already been merged. #678

@manishrw
Copy link
Contributor

manishrw commented Oct 9, 2024

Hey @arpitbbhayani @lucifercr07! Does this need something more to be closed? We've already added the command HSCAN with tests.

@lucifercr07
Copy link
Contributor

Closing, merged as part of #645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants