Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Incorrect behavior of keyspace stats and DBSIZE command #615

Closed
apoorvyadav1111 opened this issue Sep 18, 2024 · 4 comments
Closed

BUG: Incorrect behavior of keyspace stats and DBSIZE command #615

apoorvyadav1111 opened this issue Sep 18, 2024 · 4 comments
Assignees
@apoorvyadav1111

Comments

@apoorvyadav1111
Copy link
Contributor

Hi,

While going through the code, I observed that we are incrementing the KeyspaceStat count even if the operation is not creating new keys but overwriting the existing ones. This leads to the following behavior in dice:
image
In Redis:
image
Please assign this to me, if possible.
@Abh-ay
Copy link
Contributor

Abh-ay commented Sep 19, 2024

Hi @apoorvyadav1111
can i pick this up?

@Abh-ay Abh-ay mentioned this issue Sep 19, 2024
Closed
@apoorvyadav1111
Copy link
Contributor Author

Hi @Abh-ay , I have been working on this and will be raising a PR soon. Thank you for your interest in contributing. Please keep watch on new issues.
Apoorv

@apoorvyadav1111 apoorvyadav1111 mentioned this issue Sep 20, 2024
Merged
@Abh-ay
Copy link
Contributor

Abh-ay commented Sep 21, 2024

Ok @apoorvyadav1111
I created PR also for this, should I close this request?
Thanks!!

JyotinderSingh added a commit that referenced this issue Sep 23, 2024
@apoorvyadav1111 @ayadav16 @JyotinderSingh
#616 & #615: fixes keyspacestats and flushdb (#630)
d84c218 
Co-authored-by: ayadav16 <ayadav7@binghamton.edu>
Co-authored-by: Jyotinder Singh <jyotindrsingh@gmail.com>
@JyotinderSingh
Copy link
Collaborator

Ok @apoorvyadav1111 I created PR also for this, should I close this request? Thanks!!

Please only begin working on an issue if it is assigned to you. This helps avoid duplicate efforts.

shardul08 pushed a commit to shardul08/dice that referenced this issue Sep 23, 2024
@apoorvyadav1111 @ayadav16
@JyotinderSingh @shardul08
DiceDB#616 & DiceDB#615: fixes keyspacestats and flushdb (DiceDB#630)
a5d5b10 
Co-authored-by: ayadav16 <ayadav7@binghamton.edu>
Co-authored-by: Jyotinder Singh <jyotindrsingh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apoorvyadav1111 apoorvyadav1111

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apoorvyadav1111 @JyotinderSingh @Abh-ay