Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle root path '.' correctly in JSON.OBJLEN command #603

Closed
3 tasks
JyotinderSingh opened this issue Sep 17, 2024 · 8 comments · Fixed by #976
Closed
3 tasks

Handle root path '.' correctly in JSON.OBJLEN command #603

JyotinderSingh opened this issue Sep 17, 2024 · 8 comments · Fixed by #976

Comments

@JyotinderSingh
Copy link
Collaborator

The current implementation of JSON.OBJLEN does not correctly handle the root path '.'. This needs to be fixed to align with Redis behavior.

Current behavior:
When using JSON.OBJLEN doc ., the library is unable to parse it and returns an error.

Expected behavior:
JSON.OBJLEN doc . should return the length of the complete parent object, consistent with Redis behavior.

Additional context:

Tasks:

  • Implement the fix in evalJSONOBJLEN function
  • Add or update tests to cover this scenario
  • Ensure the fix doesn't introduce any regressions
@AshikBN
Copy link
Contributor

AshikBN commented Sep 18, 2024

@JyotinderSingh pls assign this to me.

@JyotinderSingh
Copy link
Collaborator Author

@JyotinderSingh pls assign this to me.

Assigned.

@HassanAarzoo
Copy link

@AshikBN Are you working on this? If not I would like to pick this up

@AshikBN
Copy link
Contributor

AshikBN commented Sep 20, 2024

i have not yet, you can start if you are interested
@JyotinderSingh Can this be assigned to @HassanAarzoo Please

@kapishmalik
Copy link
Contributor

@JyotinderSingh I am also interested to work on this issue

@arpitbbhayani
Copy link
Contributor

Hello @AshikBN,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@iamskp11
Copy link
Contributor

iamskp11 commented Oct 5, 2024

Hey @JyotinderSingh, requesting you to assign this to me. Would like to fix this particular case.

@JyotinderSingh
Copy link
Collaborator Author

Hey @JyotinderSingh, requesting you to assign this to me. Would like to fix this particular case.

Assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants