Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Redis SELECT command #569

Closed
JyotinderSingh opened this issue Sep 13, 2024 · 4 comments · Fixed by #574
Closed

Add support for Redis SELECT command #569

JyotinderSingh opened this issue Sep 13, 2024 · 4 comments · Fixed by #574

Comments

@JyotinderSingh
Copy link
Collaborator

Add support for the SELECT command in DiceDB similar to the SELECT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@JyotinderSingh
Copy link
Collaborator Author

While DiceDB currently doesn't support multiple logical databases, we need to support this command to unblock certain other tasks.

For now this can be implemented as a dummy command which just responds with RespOk.

@codeasashu
Copy link
Contributor

@JyotinderSingh Can I work on this please?

@JyotinderSingh
Copy link
Collaborator Author

@JyotinderSingh Can I work on this please?

Assigned

@JyotinderSingh JyotinderSingh changed the title Add support for Redis SELECT command Add support for Redis SELECT command Sep 13, 2024
@codeasashu
Copy link
Contributor

@JyotinderSingh can you review PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants